Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: allow ->* without a space #205

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Bug fix: allow ->* without a space #205

merged 5 commits into from
Nov 25, 2024

Conversation

Dtenwolde
Copy link
Collaborator

Fixes cwida/duckpgq-extension#146

A bug we previously experienced was that there had to be a space between (-> or -) and * to be properly parsed. This PR fixes that.

peter and others added 4 commits November 18, 2024 23:33
… and *

- add new lexical symbols for <- and <->
- reshape the pgq.y grammar rules to use these
now, we allow them

so the <-> and <- symbols were removed again.

This change of thought was triggered by the mayhem the new lexical
symbols were causing:

================================================================================
Query unexpectedly failed (test/optimizer/move_constants.test:101)
================================================================================
EXPLAIN SELECT -1*X<-5 FROM test;
================================================================================
Actual result:
Parser Error: syntax error at or near "<-"
LINE 1: EXPLAIN SELECT -1*X<-5 FROM test

but the main result of this PR is still: you can now type ->* without spaces
@Dtenwolde Dtenwolde merged commit 6236d0b into main Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error at or near ->*
1 participant